RachitSharma2001 commented on PR #28930:
URL: https://github.com/apache/airflow/pull/28930#issuecomment-1383223870

   Sounds good! I have integrated the requested changes in my latest push. 
   
   However, in terms of the documentation, I think it will already 
automatically be added to the templates reference. This is because this macro 
is a macro function, specified in 
[airflow/macros](https://github.com/RachitSharma2001/airflow/blob/airflow_json_loads/airflow/macros/__init__.py)
 along with `ds_add`, `ds_format`, `datetime_diff_for_humans`). In the bottom 
of 
[templates_ref.rst](https://github.com/RachitSharma2001/airflow/blob/airflow_json_loads/docs/apache-airflow/templates-ref.rst),
 it loads the documentation provided for each function in the that macro file. 
So I think the documentation I added to the `json_loads` macro (specified in 
the 
[comment](https://github.com/RachitSharma2001/airflow/blob/airflow_json_loads/airflow/macros/__init__.py#L92)
 provided under the function) will actually be linked in the templates 
reference. Let me know if this is correct or if my understanding is wrong.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to