uranusjr commented on code in PR #28894:
URL: https://github.com/apache/airflow/pull/28894#discussion_r1070983117


##########
airflow/www/app.py:
##########
@@ -81,10 +82,18 @@ def create_app(config=None, testing=False):
 
     flask_app.config["PERMANENT_SESSION_LIFETIME"] = 
timedelta(minutes=settings.get_session_lifetime_config())
     flask_app.config.from_pyfile(settings.WEBSERVER_CONFIG, silent=True)
-    flask_app.config["APP_NAME"] = conf.get(section="webserver", 
key="instance_name", fallback="Airflow")
     flask_app.config["TESTING"] = testing
     flask_app.config["SQLALCHEMY_DATABASE_URI"] = conf.get("database", 
"SQL_ALCHEMY_CONN")
 
+    instance_name = conf.get(section="webserver", key="instance_name", 
fallback="Airflow")
+    instance_name_has_markup = conf.getboolean(
+        section="webserver", key="instance_name_has_markup", fallback=False
+    )
+    if instance_name_has_markup:
+        instance_name = re.sub(r"<[^<]+?>", "", instance_name)

Review Comment:
   Actually it is easier than I thought!
   
   ```python
   import html.parser
   
   def strip_tags(inp: str) -> str:
       parts: list[str] = []
   
       class TagStripParser(html.parser.HTMLParser):
           def handle_data(self, d: str) -> None:
               parts.append(d)
   
       TagStripParser().feed(inp)
       return "".join(parts)
   ```
   
   ```pycon
   >>> strip_tags("<b>Bold Site <span>Title</span> Test &amp;</b>")
   'Bold Site Title Test &'
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to