rafalh commented on code in PR #28970:
URL: https://github.com/apache/airflow/pull/28970#discussion_r1071454703
##########
tests/providers/google/cloud/hooks/test_dataproc.py:
##########
@@ -1006,17 +1006,9 @@ def test_set_python_main(self):
self.builder.set_python_main(main)
assert main ==
self.builder.job["job"][self.job_type]["main_python_file_uri"]
- @pytest.mark.parametrize(
- "job_name",
- [
- pytest.param("name", id="simple"),
- pytest.param("name_with_dash", id="name with underscores"),
- pytest.param("group.name", id="name with dot"),
- pytest.param("group.name_with_dash", id="name with dot and
underscores"),
- ],
- )
Review Comment:
They were added with sanitization (dot substitution) in
`DataProcJobBuilder`. Now that I removed sanitization from that class all test
cases with dots would fail. I just reverted this test to the state before the
changes in `DataProcJobBuilder` and added a test that checks if proper job_id
is passed from the operator instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
