o-nikolas commented on code in PR #28925:
URL: https://github.com/apache/airflow/pull/28925#discussion_r1071561782
##########
airflow/providers/amazon/aws/operators/glue.py:
##########
@@ -144,6 +149,20 @@ def execute(self, context: Context):
self.wait_for_completion,
)
glue_job_run = glue_job.initialize_job(self.script_args,
self.run_job_kwargs)
+ glue_job_run_url = (
+ f"{BASE_AWS_CONSOLE_LINK}/gluestudio/home?"
+ +
f"region={glue_job.conn_region_name}#/job/{urllib.parse.quote(self.job_name,
safe='')}/run/"
+ + glue_job_run["JobRunId"]
+ )
Review Comment:
Thanks for the PR!
Could you not reuse the format string from the Link class so as to not
duplicate it here? The two could easily get out of sync. Something like (NOTE:
untested):
```suggestion
glue_job_run_url = GlueJobRunDetailsLink.format_str.format(
region_name=glue_job.conn_region_name,
job_name=urllib.parse.quote(self.job_name, safe=''),
job_run_id=glue_job_run["JobRunId"])
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
