hussein-awala commented on code in PR #28961:
URL: https://github.com/apache/airflow/pull/28961#discussion_r1071620409
##########
airflow/dag_processing/processor.py:
##########
@@ -484,7 +486,13 @@ def manage_slas(self, dag: DAG, session: Session = None)
-> None:
callback(dag, task_list, blocking_task_list, slas,
blocking_tis)
notification_sent = True
except Exception:
- Stats.incr("sla_callback_notification_failure")
+ Stats.incr(
+ "sla_callback_notification_failure",
+ tags={
+ "dag_id": dag.dag_id,
+ "func_name": callback.func_name, # type:
ignore[attr-defined]
Review Comment:
Actually this is the way to get the callback name in python 2, but it's
removed in python 3 and replaced by `callback.__name__`, so we need to fix this.
Would you prefer I fix it here or in a separate PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
