Taragolis commented on code in PR #28979:
URL: https://github.com/apache/airflow/pull/28979#discussion_r1072011356
##########
airflow/providers/papermill/operators/papermill.py:
##########
@@ -33,6 +33,8 @@
class NoteBook(File):
"""Jupyter notebook"""
+ template_fields: ClassVar = {*File.template_fields, "parameters"}
Review Comment:
I guess you mean `ClassVar[Sequence[str]]` instead of just `ClassVar[str] `
However even with with this annotation I got
``` console
error: Incompatible types in assignment (expression has type "Set[str]",
variable has type "Sequence[str]") [assignment]
```
So I change wrap value to tuple
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
