Taragolis commented on PR #28990:
URL: https://github.com/apache/airflow/pull/28990#issuecomment-1386151192

   During investigation found interesting bug in 
`airflow.utils.log.logging_mixin.StreamLogWriter` which unfortunetly not happen 
with this test but anyway want to share.
   
   First of all how to reproduce:
   1. Set `AIRFLOW__LOGGING__LOGGING_LEVEL=DEBUG`
   2. Run test `pytest 
tests/jobs/test_local_task_job.py::TestLocalTaskJob::test_process_sigterm_works_with_retries
 -s`
   3. Check [task 
logs](https://github.com/apache/airflow/files/10439737/attempt.1.log)
   
   I think the issue happen when different threads tried to call 
StreamLogWriter `write` method or `flush` as result it cause RecursionError. 
The fix should be easy to implement - lock write or flush method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to