uranusjr commented on code in PR #28942:
URL: https://github.com/apache/airflow/pull/28942#discussion_r1073114685
##########
airflow/providers/cncf/kubernetes/decorators/kubernetes.py:
##########
@@ -82,15 +84,35 @@ def _get_python_source(self):
res = remove_task_decorator(res, "@task.kubernetes")
return res
+ def _generate_cmds(self):
+ return [
+ "bash",
+ "-cx",
+ (
+ f"{_generate_decoded_command('%s', '%s')} && " %
(_PYTHON_SCRIPT_ENV, _FILENAME_IN_CONTAINER)
Review Comment:
Also I realised as I was writing the above comment, naively wrapping the
value in single quotes is not a good idea. You likely want to use `shlex.quote`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
