uranusjr commented on code in PR #28724:
URL: https://github.com/apache/airflow/pull/28724#discussion_r1073117006
##########
tests/jobs/test_backfill_job.py:
##########
@@ -147,31 +147,24 @@ def test_dag_run_with_finished_tasks_set_to_success(self,
dag_maker):
assert State.SUCCESS == dag_run.state
- @pytest.mark.xfail(condition=True, reason="This test is flaky")
@pytest.mark.backend("postgres", "mysql")
- def test_trigger_controller_dag(self):
+ def test_trigger_controller_dag(self, session):
dag = self.dagbag.get_dag("example_trigger_controller_dag")
target_dag = self.dagbag.get_dag("example_trigger_target_dag")
target_dag.sync_to_db()
- # dag_file_processor = DagFileProcessor(dag_ids=[], log=Mock())
- task_instances_list = []
- # task_instances_list = dag_file_processor._process_task_instances(
- # target_dag,
- # dag_runs=DagRun.find(dag_id='example_trigger_target_dag')
- # )
- assert not task_instances_list
+ target_dag_run = session.query(DagRun).filter(DagRun.dag_id ==
target_dag.dag_id).one_or_none()
+ assert not target_dag_run
job = BackfillJob(
dag=dag, start_date=DEFAULT_DATE, end_date=DEFAULT_DATE,
ignore_first_depends_on_past=True
)
job.run()
- task_instances_list = []
- # task_instances_list = dag_file_processor._process_task_instances(
- # target_dag,
- # dag_runs=DagRun.find(dag_id='example_trigger_target_dag')
- # )
+ dag_run = session.query(DagRun).filter(DagRun.dag_id ==
dag.dag_id).one_or_none()
+ assert dag_run
Review Comment:
```suggestion
assert dag_run is not None
```
##########
tests/jobs/test_backfill_job.py:
##########
@@ -147,31 +147,24 @@ def test_dag_run_with_finished_tasks_set_to_success(self,
dag_maker):
assert State.SUCCESS == dag_run.state
- @pytest.mark.xfail(condition=True, reason="This test is flaky")
@pytest.mark.backend("postgres", "mysql")
- def test_trigger_controller_dag(self):
+ def test_trigger_controller_dag(self, session):
dag = self.dagbag.get_dag("example_trigger_controller_dag")
target_dag = self.dagbag.get_dag("example_trigger_target_dag")
target_dag.sync_to_db()
- # dag_file_processor = DagFileProcessor(dag_ids=[], log=Mock())
- task_instances_list = []
- # task_instances_list = dag_file_processor._process_task_instances(
- # target_dag,
- # dag_runs=DagRun.find(dag_id='example_trigger_target_dag')
- # )
- assert not task_instances_list
+ target_dag_run = session.query(DagRun).filter(DagRun.dag_id ==
target_dag.dag_id).one_or_none()
+ assert not target_dag_run
Review Comment:
```suggestion
assert target_dag_run is None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
