phanikumv commented on code in PR #29014:
URL: https://github.com/apache/airflow/pull/29014#discussion_r1073695339


##########
airflow/providers/dbt/cloud/operators/dbt.py:
##########
@@ -91,8 +96,17 @@ def __init__(
         timeout: int = 60 * 60 * 24 * 7,
         check_interval: int = 60,
         additional_run_config: dict[str, Any] | None = None,
+        deferrable: bool = False,
         **kwargs,
     ) -> None:
+        # TODO: Remove once deprecated
+        if wait_for_termination:
+            warnings.warn(
+                "Argument `wait_for_termination` will be deprecated and 
removed "
+                "in a future release.  Please use  `deferrable` instead.",
+                DeprecationWarning,
+                stacklevel=2,
+            )

Review Comment:
   OK, I will make the new deferrable flag logic specific to users who use 
Triggerer. However across the repo we have lot of BigQuery operators which have 
deferrable flag. So in future we'll need to have deferrable param across the 
repo instead of `wait_for_termination`
   
   cc @potiuk @kaxil 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to