hussein-awala commented on code in PR #28777:
URL: https://github.com/apache/airflow/pull/28777#discussion_r1074037887
##########
airflow/utils/json.py:
##########
@@ -71,7 +75,7 @@ def default(self, o: Any) -> Any:
return data[DATA]
return data
except TypeError:
- raise
+ return repr(o)
Review Comment:
I'm not sure that returning `repr(o)` whatever the o type is a good idea,
but I'm trying to generalize this, where we cannot handle all the types
especially the user custom classes, so instead of raising an exception, we can
return the value as string since it's just to show it in the UI.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
