ashb commented on code in PR #29019:
URL: https://github.com/apache/airflow/pull/29019#discussion_r1081423987
##########
airflow/serialization/serde.py:
##########
@@ -260,11 +262,11 @@ def _stringify(classname: str, version: int, value: T |
None) -> str:
s = f"{classname}@version={version}("
if isinstance(value, _primitives):
s += f"{value})"
- elif isinstance(value, _iterables):
- s += ",".join(str(serialize(value, False)))
+ elif isinstance(value, _collections):
+ s += ",".join(str(serialize(value)))
Review Comment:
A nice addition to the tests along side the round trip tests would be to
verify what the serialized form ends up as
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
