ecerulm commented on code in PR #29016:
URL: https://github.com/apache/airflow/pull/29016#discussion_r1082180416
##########
airflow/utils/log/secrets_masker.py:
##########
@@ -200,10 +222,18 @@ def _redact(self, item: Redactable, name: str | None,
depth: int) -> Redacted:
if name and should_hide_value_for_key(name):
return self._redact_all(item, depth)
if isinstance(item, dict):
- return {
+ to_return = {
dict_key: self._redact(subval, name=dict_key, depth=(depth
+ 1))
for dict_key, subval in item.items()
}
+ return to_return
+ elif isinstance(item, ConvertableToDict): # things like V1EnvVar
Review Comment:
The other alternative to avoid introducing a dependency to V1EnvVar would be
to mask everything that is not explicitly `Redactable`. Which one shall I go
for? the `ConvertableToDict`, introducing a dependency to `V1EnvVar` or mask
everything not redactable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
