vincbeck commented on code in PR #28502:
URL: https://github.com/apache/airflow/pull/28502#discussion_r1082796111
##########
airflow/dag_processing/processor.py:
##########
@@ -365,8 +365,10 @@ def __init__(self, dag_ids: list[str] | None,
dag_directory: str, log: logging.L
self._dag_directory = dag_directory
self.dag_warnings: set[tuple[str, str]] = set()
+ @staticmethod
+ @internal_api_call
@provide_session
- def manage_slas(self, dag: DAG, session: Session = None) -> None:
+ def manage_slas(dag_folder, dag_id: str, log: logging.Logger, session:
Session = NEW_SESSION) -> None:
Review Comment:
See the method `get_log` I added
[here](https://github.com/apache/airflow/pull/28502/files#diff-af25dd96233a97ace811c614fa7d5bd059cbbc1571e421f6675e16f6290814c5R71).
It is literally a duplicate of the property log defined just below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
