potiuk opened a new pull request, #29080: URL: https://github.com/apache/airflow/pull/29080
There were couple of "teething" problems with generated stubs in the common.sql package: * formatting of the black for ... methods was slightly different when running via black pre-commit vs. built-in black formatting (hard to say why) * EOL at the end of generated file was missing, leading to EOL fixer adding them after generation leading to multiple pre-commit passes * Union was missing in the generated stubs (this is a known issue with stubgen: https://github.com/python/mypy/issues/12929 * Intellij complained on Incomplete import from _typeshed missing This PR fixes all the problems: disables external black for the generated files, adds EOL and improves post-processing of the generated stub files to add missing Union and noqa for _typeshed import. As the end result, generated stub files are fully importable (no errors reported by IntelliJ IDE) and stable for regeneration. <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
