dstandish commented on PR #27758: URL: https://github.com/apache/airflow/pull/27758#issuecomment-1399216248
Ok @potiuk so we have now logs in single pane. Tested working with all handlers except alibaba, the hook for which is missing some basic (and needed) methods such as list_keys. Anyway, 2.6 should be compatible with older handlers, and conversele we should not need to bump major version for providers (though in both cases they won't have the trigger functionality). Re the optimization to limit concurrent files, I did do a POC for that. But instead of adding that to this PR, I propose we leave that for a followup. I think it's reasonable because the PR is big enough as it is, and I have added the capability to entirely disable the trigger handler manipulation (undocumented param, following the example for task logger). So, users can easily disable this feature for any reason, in case the files thing proves to be an issue and the optimization for whatever reason does not materialize before 2.6. So, if you accept that, I think that this PR is essentially complete and ready for review from a feature / design perspective. Though I need still to fix some tests that recent change broke, and maybe add a few more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
