Taragolis commented on code in PR #29081:
URL: https://github.com/apache/airflow/pull/29081#discussion_r1083296814


##########
scripts/in_container/verify_providers.py:
##########
@@ -254,6 +254,16 @@ class ProviderPackageDetails(NamedTuple):
     ),
 }
 
+# If provided parse USE_AIRFLOW_VERSION environment variable and construct 
tuple (major, minor, path)

Review Comment:
   I would better try to make this command more consistent with other command 
in `breeze release-management verify-provider-packages`
   
   
https://github.com/apache/airflow/blob/af9143eacdff62738f6064ae7556dd8f4ca8d96d/dev/breeze/src/airflow_breeze/commands/release_management_commands.py#L484-L518
   
   So if we change version here we do not need to change it again in 
`scripts/in_container/verify_providers.py`
   
   
https://github.com/apache/airflow/blob/af9143eacdff62738f6064ae7556dd8f4ca8d96d/.github/workflows/ci.yml#L757-L761



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to