Taragolis commented on code in PR #29034:
URL: https://github.com/apache/airflow/pull/29034#discussion_r1083327542
##########
airflow/models/baseoperator.py:
##########
@@ -1184,7 +1197,29 @@ def render_template_fields(
"""
if not jinja_env:
jinja_env = self.get_template_env()
- self._do_render_template_fields(self, self.template_fields, context,
jinja_env, set())
+
+ if self.template_all_fields:
+ templatable_fields = (
+ set(self.__dict__.keys())
+ - set(BaseOperator.__dict__.keys())
+ - set(partial(operator_class=self.__class__,
task_id=self.task_id).kwargs.keys())
+ )
Review Comment:
Well I guess better create some restricted frozen set and keep all
parameters which never rendered (I think all of BaseOperator) we also could use
this set as reference for end users. It is quite common question "Why I can't
render `pool`, `executor_config`, `retries` and etc"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
