potiuk commented on code in PR #29098:
URL: https://github.com/apache/airflow/pull/29098#discussion_r1084421411


##########
dev/README_RELEASE_AIRFLOW.md:
##########
@@ -477,8 +496,12 @@ To do this we need to
     twine upload -r pypitest dist/*
     ```
 
-- Verify that the test package looks good by downloading it and installing it 
into a virtual environment. The package download link is available at:
-https://test.pypi.org/project/apache-airflow/#files
+- Copy the package tar.gz download link available at 
https://test.pypi.org/project/apache-airflow/#files. Verify that the test 
package looks good by
+installing it with the constraint file into a new virtual environment. (adapt 
the constraint file python version to your virtual env setup)
+
+    ```shell script
+    pip install 
https://test-files.pythonhosted.org/packages/98/2c/82009f7760f341cc4e12c44da657c906415130ca60cd201d05e9b38caa38/apache-airflow-2.2.1rc1.tar.gz
 --constraint 
https://raw.githubusercontent.com/apache/airflow/constraints-2.2.1rc1/constraints-3.8.txt

Review Comment:
   Yes. we need to add same constraints (I just did not add them in my example).
   
   Hmm. I always had a trouble when installing only from "test.pypi" because 
some dependent packages were not installed there (not everyone uses test.pypi 
to test their packages). So once you add constraints, I think without the 
--extra-index-url things might start failing because specific versions of 
dependencies in the constraints might be missing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to