ephraimbuddy commented on code in PR #28998:
URL: https://github.com/apache/airflow/pull/28998#discussion_r1085292324


##########
airflow/api_connexion/endpoints/dag_run_endpoint.py:
##########
@@ -280,6 +285,12 @@ def get_dag_runs_batch(*, session: Session = NEW_SESSION) 
-> APIResponse:
     ],
 )
 @provide_session
+@action_logging(
+    event=action_event_from_permission(
+        prefix="log",

Review Comment:
   > The same, as above. In other places we are logging the "main" object to 
its correspondent table. For instance, in connection_endpoint.py we are logging 
the Connection object to connection table. In variable_endpoint.py we are 
logging the Variable object to variable table.
   
   This is wrong. The logging is all done in the log table through the 
`action_logging` decorator. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to