jedcunningham commented on code in PR #29135:
URL: https://github.com/apache/airflow/pull/29135#discussion_r1085734976
##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -242,7 +242,10 @@ def get_credentials_and_project_id(self) ->
tuple[google.auth.credentials.Creden
keyfile_dict: str | None = self._get_field("keyfile_dict", None)
Review Comment:
```suggestion
keyfile_dict: str | dict[str, str] | None =
self._get_field("keyfile_dict", None)
```
##########
airflow/providers/google/common/hooks/base_google.py:
##########
@@ -491,7 +494,7 @@ def provide_gcp_credential_file_as_context(self) ->
Generator[str | None, None,
file in ``GOOGLE_APPLICATION_CREDENTIALS`` environment variable.
"""
key_path: str | None = self._get_field("key_path", None)
- keyfile_dict: str | None = self._get_field("keyfile_dict", None)
+ keyfile_dict: str | dict | None = self._get_field("keyfile_dict", None)
Review Comment:
```suggestion
keyfile_dict: str | dict[str, str] | None =
self._get_field("keyfile_dict", None)
```
Probably should be a little more "strict" with what we accept?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
