vandonr-amz commented on code in PR #29165:
URL: https://github.com/apache/airflow/pull/29165#discussion_r1087091128
##########
tests/system/providers/amazon/aws/example_sagemaker.py:
##########
@@ -161,8 +161,12 @@ def _build_and_upload_docker_image(preprocess_script,
repository_uri):
docker_build_and_push_commands = f"""
cp /root/.aws/credentials /tmp/credentials &&
+ # login to public ecr repo containing amazonlinux image
+ docker login --username {username} --password {password}
public.ecr.aws
Review Comment:
oh well maybe we don't need to ? I followed the instructions on
https://docs.aws.amazon.com/AmazonECR/latest/userguide/amazon_linux_container_image.html
which are to 1) login 2) pull.
Since we have the credentials laying around here, it's not much effort, so
I'd keep it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
