snjypl commented on PR #29188: URL: https://github.com/apache/airflow/pull/29188#issuecomment-1405818900
Hi Team @potiuk @mhenc @mhenc this task appears to be more complex than i expected. i went through the [AIP 44, ](https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-44+Airflow+Internal+API), and the PRs for the other tasks to get a better understanding. in AIP-44, i found a reference to the `save_dag_to_db` method. > This is a new, “heaviest” method that should be exposed by the internal API to the DAG processor. We should be able to serialize all the information stored currently in the DagBag and send it to the Internal API server. The method should be roughly equivalent to: sync_to_db and pickling dags if set. This should be done in a single transaction as a single API call. based on my understanding so far, i have done a rough refactoring to see if i am in the right direction. it will be really helpful if anyone could take a look at the changes. it is just a rough changes, i wanted to see if i understand the task correctly. from the AIP, i got the impression that we would be sending the serialized dag to the internal api. will `BaseSerialization.serialize` in the `internal_api_call` decorator take care about the serialization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
