potiuk commented on code in PR #29213:
URL: https://github.com/apache/airflow/pull/29213#discussion_r1089924848
##########
.github/workflows/ci.yml:
##########
@@ -1017,7 +1017,7 @@ jobs:
BACKEND: "postgres"
PYTHON_MAJOR_MINOR_VERSION:
"${{needs.build-info.outputs.default-python-version}}"
POSTGRES_VERSION:
"${{needs.build-info.outputs.default-postgres-version}}"
- BACKEND_VERSION: "${{needs.build-info.outputs.default-python-version}}"
+ BACKEND_VERSION: "${{needs.build-info.outputs.default-postgres-version}}"
Review Comment:
BACKEND_VERSION has only ben used for coverage as unique id (that's why it
was wroking BTW) so maybe we could rename it to UNIQUE_COVERAGE_KEY or
something?
##########
.github/workflows/ci.yml:
##########
@@ -1017,7 +1017,7 @@ jobs:
BACKEND: "postgres"
PYTHON_MAJOR_MINOR_VERSION:
"${{needs.build-info.outputs.default-python-version}}"
POSTGRES_VERSION:
"${{needs.build-info.outputs.default-postgres-version}}"
- BACKEND_VERSION: "${{needs.build-info.outputs.default-python-version}}"
+ BACKEND_VERSION: "${{needs.build-info.outputs.default-postgres-version}}"
Review Comment:
BACKEND_VERSION has only ben used for coverage as unique id (that's why it
was working BTW) so maybe we could rename it to UNIQUE_COVERAGE_KEY or
something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
