uranusjr commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1090182988
##########
airflow/executors/base_executor.py:
##########
@@ -355,14 +355,15 @@ def execute_async(
"""
raise NotImplementedError()
- def get_task_log(self, ti: TaskInstance, log: str = "") -> None | str |
tuple[str, dict[str, bool]]:
+ def get_task_log(self, ti: TaskInstance) -> tuple[list[str], list[str]]:
Review Comment:
FileTaskHandler has this pattern that would break after this signature
change:
```python
response = executor.get_task_log(ti=ti)
if response:
...
```
Also need to fix tests that currently use the removed `log` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
