uranusjr commented on code in PR #27776:
URL: https://github.com/apache/airflow/pull/27776#discussion_r1090331638
##########
airflow/providers/google/cloud/hooks/dataflow.py:
##########
@@ -723,6 +702,40 @@ def start_template_dataflow(
jobs_controller.wait_for_done()
return response["job"]
+ def _update_environment(self, variables: dict, environment: dict | None =
None) -> dict:
+ environment = environment or {}
+ # available keys for runtime environment are listed here:
+ #
https://cloud.google.com/dataflow/docs/reference/rest/v1b3/RuntimeEnvironment
+ environment_keys = {
+ "numWorkers",
+ "maxWorkers",
+ "zone",
+ "serviceAccountEmail",
+ "tempLocation",
+ "bypassTempDirValidation",
+ "machineType",
+ "additionalExperiments",
+ "network",
+ "subnetwork",
+ "additionalUserLabels",
+ "kmsKeyName",
+ "ipConfiguration",
+ "workerRegion",
+ "workerZone",
+ }
+
+ def _check_one(key, val):
+ if key in environment:
+ self.log.warning(
+ "%r parameter in 'variables' will override of " "the same
one passed in 'environment'!",
Review Comment:
```suggestion
"%r parameter in 'variables' will override the same one
passed in 'environment'!",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
