potiuk commented on code in PR #27776: URL: https://github.com/apache/airflow/pull/27776#discussion_r1090486887
########## airflow/providers/google/provider.yaml: ########## @@ -85,6 +85,7 @@ dependencies: - google-cloud-build>=3.0.0 - google-cloud-compute>=0.1.0,<2.0.0 - google-cloud-container>=2.2.0,<3.0.0 + - google-cloud-dataflow-client>=0.5.2,<0.5.5 Review Comment: Can you please add a comment there why ? I know it's not there for the others but we have generally adopted the approach that whenever we upper-bound a dependency we SHOULD add a comment specifiying why the upper-binding is there and what is the condition for it to be removed. https://github.com/apache/airflow#approach-to-dependencies-of-airflow : > Whenever we upper-bound such a dependency, we should always comment why we are doing it - i.e. we should have a good reason why dependency is upper-bound. And we should also mention what is the condition to remove the binding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
