potiuk commented on code in PR #29234:
URL: https://github.com/apache/airflow/pull/29234#discussion_r1090521578
##########
generated/provider_dependencies.json:
##########
@@ -343,7 +343,7 @@
"google-cloud-dataplex>=0.1.0",
"google-cloud-dataproc-metastore>=1.2.0,<2.0.0",
"google-cloud-dataproc>=3.1.0",
- "google-cloud-dlp>=0.11.0,<2.0.0",
+ "google-cloud-dlp>=3.0.0,<4.0.0",
Review Comment:
Could you please describe in the comment why we (still) upper bound it -
following the rules we adopted recently ? (I know we do not have it for other
cases but might be a good idea to add similar comments to others):
https://github.com/apache/airflow#approach-to-dependencies-of-airflow
> Whenever we upper-bound such a dependency, we should always comment why we
are doing it - i.e. we should have a good reason why dependency is upper-bound.
And we should also mention what is the condition to remove the binding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
