ashb commented on a change in pull request #5543: Fix permission error when
creating logs
URL: https://github.com/apache/airflow/pull/5543#discussion_r303041013
##########
File path: airflow/utils/log/file_processor_handler.py
##########
@@ -84,7 +84,7 @@ def close(self):
self.handler.close()
def _render_filename(self, filename):
- filename = os.path.relpath(filename, self.dag_dir)
+ filename = os.path.relpath(filename, self.dag_dir).replace("../", "")
Review comment:
Not just hacky but wrong - this will completely change the path it writes to
if it contains `../`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
