uranusjr commented on code in PR #28846: URL: https://github.com/apache/airflow/pull/28846#discussion_r1091586216
########## airflow/compat/hashlib_wrapper.py: ########## @@ -0,0 +1,45 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import hashlib +import sys +from typing import Any + +# Check if "usedforsecurity" is available for hashlib +if sys.version_info >= (3, 9): + HAS_USEDFORSECURITY = True +else: + HAS_USEDFORSECURITY = False + + +def md5(data: Any, used_for_security: bool | None = None): Review Comment: Naming a submodule with the same name as a top-level module is not a problem (not in Python 3 anyway) since `airflow.compat.hashlib` and `hashlib` can never conflict. The `_wrapper` or `_compat` suffix is simply redundant. If you really feel strongly about having a suffix (this particular case is slightly different from `functools` since the `md5` function is a wrapper, not a shim), you can choose to put the module in `airflow.utils` or even directly under `airflow` (a la `airflow.typing_compat`) instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
