ephraimbuddy commented on code in PR #29058:
URL: https://github.com/apache/airflow/pull/29058#discussion_r1092132580
##########
airflow/utils/db_cleanup.py:
##########
@@ -123,6 +127,15 @@ def _check_for_rows(*, query: Query, print_rows=False):
return num_entities
+def _dump_table_to_file(*, target_table, file_path, export_format, session):
+ if export_format == "csv":
Review Comment:
Actually, this is for future works that would add extra format options, so
for json, we could say `if export_format=="json"`. we have protection on the
choices using argparse `choices`. Do you suggest I add the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
