vandonr-amz commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1092359626
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -679,11 +697,11 @@ def __init__(
self.check_interval = check_interval
self.max_ingestion_time = max_ingestion_time
self.check_if_job_exists = check_if_job_exists
- if action_if_job_exists in ("increment", "fail"):
+ if action_if_job_exists in {"random", "increment", "fail"}:
Review Comment:
well there is the "every change is a breaking change" philosophy of course,
and _maybe_ I can imagine a workflow where changing this would be breaking, but
it'd be pretty far fetched.
I can always keep the existing behavior, but I'd put big deprecation
warnings around it, because let's say you run 10 jobs a day, you'd be looking
at throttling exceptions after 2-3 years, which is not such a long time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
