dstandish commented on code in PR #27758:
URL: https://github.com/apache/airflow/pull/27758#discussion_r1092489357
##########
airflow/executors/base_executor.py:
##########
@@ -355,14 +355,15 @@ def execute_async(
"""
raise NotImplementedError()
- def get_task_log(self, ti: TaskInstance, log: str = "") -> None | str |
tuple[str, dict[str, bool]]:
+ def get_task_log(self, ti: TaskInstance) -> tuple[list[str], list[str]]:
Review Comment:
this bit
```
response = executor.get_task_log(ti=ti)
if response:
executor_messages, executor_logs = response
```
it's a remnant from when if `get_task_log` not implemented then would return
None, but i have since updated baseexecutor implementation to return `[], []`
so that bit of defensiveness is not strictly necessary, though it doesn't hurt.
i have fixed tests, hopefully not too many more iterations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
