eladkal commented on code in PR #29245:
URL: https://github.com/apache/airflow/pull/29245#discussion_r1092504689
##########
airflow/providers/amazon/aws/operators/sagemaker.py:
##########
@@ -654,8 +673,8 @@ class SageMakerTrainingOperator(SageMakerBaseOperator):
the operation does not timeout.
:param check_if_job_exists: If set to true, then the operator will check
whether a training job
already exists for the name in the config.
- :param action_if_job_exists: Behaviour if the job name already exists.
Possible options are "increment"
- (default) and "fail".
+ :param action_if_job_exists: Behaviour if the job name already exists.
Possible options are "random"
+ (default), "increment" (deprecated) and "fail".
Review Comment:
No, my comment is that we consider value deprecated yet the code does not
raise deprecation warning.
If something is deprecated it must have deprecation warning that lead users
to set the proper values/parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
