mhenc commented on code in PR #29099:
URL: https://github.com/apache/airflow/pull/29099#discussion_r1093142937
##########
airflow/models/trigger.py:
##########
@@ -71,27 +72,30 @@ def __init__(self, classpath: str, kwargs: dict[str, Any],
created_date: datetim
self.kwargs = kwargs
self.created_date = created_date or timezone.utcnow()
- @classmethod
- def from_object(cls, trigger: BaseTrigger):
+ @staticmethod
Review Comment:
Just a nit:
`@internal_api_call` works fine with `@classmethod`
see
https://github.com/apache/airflow/blob/main/airflow/dag_processing/processor.py#L368
so these changes are not needed - I am not sure if it can break anything,
unless someone decides to inherit from `Trigger` class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
