josh-fell commented on code in PR #29274:
URL: https://github.com/apache/airflow/pull/29274#discussion_r1093485398
##########
airflow/providers/amazon/aws/sensors/redshift_cluster.py:
##########
@@ -56,8 +56,14 @@ def __init__(
self.aws_conn_id = aws_conn_id
def poke(self, context: Context):
- self.log.info("Poking for status : %s\nfor cluster %s",
self.target_status, self.cluster_identifier)
- return self.hook.cluster_status(self.cluster_identifier) ==
self.target_status
+ current_status = self.hook.cluster_status(self.cluster_identifier)
+ self.log.info(
+ "Poked cluster %s for status '%s', found status '%s'",
Review Comment:
Yes. Just merely a suggestion for readability and maybe a little
future-proofing with all of those statuses if there is some Enum to be created
with a nice repr. Certainly isn't a blocking suggestion to use repr or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
