vincbeck commented on code in PR #28900:
URL: https://github.com/apache/airflow/pull/28900#discussion_r1095922339
##########
airflow/models/dag.py:
##########
@@ -1314,23 +1356,28 @@ def handle_callback(self, dagrun, success=True,
reason=None, session=NEW_SESSION
:param reason: Completion reason
:param session: Database session
"""
- callbacks = self.on_success_callback if success else
self.on_failure_callback
- if callbacks:
- callbacks = callbacks if isinstance(callbacks, list) else
[callbacks]
- tis = dagrun.get_task_instances(session=session)
- ti = tis[-1] # get first TaskInstance of DagRun
- ti.task = self.get_task(ti.task_id)
- context = ti.get_template_context(session=session)
- context.update({"reason": reason})
- for callback in callbacks:
- self.log.info("Executing dag callback function: %s", callback)
- try:
- callback(context)
- except Exception:
- self.log.exception("failed to invoke dag state update
callback")
- Stats.incr(
- "dag.callback_exceptions", tags={"dag_id":
dagrun.dag_id, "run_id": dagrun.run_id}
- )
+ callbacks, context = DAG._fetch_callback(
+ dag=self, dagrun=dagrun, success=success, reason=reason,
session=session
+ )
+ DAG.execute_callback(callbacks, context, self.dag_id, dagrun.run_id)
Review Comment:
Nice catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
