notatallshaw-gts commented on PR #29413:
URL: https://github.com/apache/airflow/pull/29413#issuecomment-1422691322

   Looks great! I'm sure you've already thought of these use cases but just in 
case two things I'd be worried about with this style of straight lines is:
   
   1. How it looks when a task has a large number of downstream tasks (e.g. 
20+)?
   2. Is it possible to visually distinguish lines when they have to cross each 
other?
   
   The current curve lines means even it's messy the angle always allows you to 
distinguish the lines, e.g.:
   
   ```python
   import datetime
   from airflow.models import DAG
   from airflow.operators.empty import EmptyOperator
   
   
   with DAG(
       dag_id="test",
       schedule_interval="@once",
       start_date=datetime.datetime(2000, 1, 1),
   ) as test:
       upstream_tasks = [EmptyOperator(task_id=f"upstream_{i}") for i in 
range(4)]
       downstream_tasks = [EmptyOperator(task_id=f"downstream_{i}") for i in 
range(4)]
       for upstream_task in upstream_tasks:
           upstream_task >> downstream_tasks
   
       other_tasks = [EmptyOperator(task_id=f"other_{i}") for i in range(16)]
       upstream_tasks[0] >> other_tasks
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to