michaelmicheal opened a new pull request, #29446:
URL: https://github.com/apache/airflow/pull/29446
When we deactivate stale DAGs, we add a buffer to the last parsed time of a
DAG when comparing it to the last parsed time of its DAG file to account for
DAG files that take a long time to process.
```python
for dag in dags_parsed:
# The largest valid difference between a DagFileStat's
last_finished_time and a DAG's
# last_parsed_time is _processor_timeout. Longer than that
indicates that the DAG is
# no longer present in the file.
if (
dag.fileloc in last_parsed
and (dag.last_parsed_time + processor_timeout) <
last_parsed[dag.fileloc]
):
cls.logger().info("DAG %s is missing and will be
deactivated.", dag.dag_id)
to_deactivate.add(dag.dag_id)
```
The upper bound on this delay is indeed the processor timeout, but
practically speaking, this is unnecessary when we configure a long timeout.
This can result in a large delay in stale DAG deactivation. I think this buffer
should be configurable.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)**
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
