potiuk commented on code in PR #29449:
URL: https://github.com/apache/airflow/pull/29449#discussion_r1101983456
##########
scripts/ci/docker-compose/integration-statsd.yml:
##########
@@ -19,15 +19,36 @@ version: "3.7"
services:
statsd-exporter:
image: apache/airflow:airflow-statsd-exporter-2020.09.05-v0.17.0
+ container_name: "breeze-statsd-exporter"
ports:
- "9125:9125"
- "9125:9125/udp"
- "29102:9102"
+ prometheus:
+ image: prom/prometheus
+ container_name: "breeze-prometheus"
+ user: "0"
+ ports:
+ - "29090:9090"
Review Comment:
I thought for a while that what you **might** add is short "Statsd testing"
in TESTING.rst. We explain different kinds of tests we do and looking at statsd
with tests is a kind of tests. So maybe adding a chapter on how to test metrics
with Breeze there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
