ferruzzi commented on code in PR #29447:
URL: https://github.com/apache/airflow/pull/29447#discussion_r1102026640
##########
tests/providers/amazon/aws/operators/test_ecs.py:
##########
@@ -494,39 +494,47 @@ def test_check_success_task_not_raises(self, client_mock):
["", {"testTagKey": "testTagValue"}],
],
)
- @mock.patch.object(EcsRunTaskOperator, "_xcom_del")
- @mock.patch.object(
- EcsRunTaskOperator,
- "xcom_pull",
- return_value=f"arn:aws:ecs:us-east-1:012345678910:task/{TASK_ID}",
+ @pytest.mark.parametrize(
+ "arns, expected_arn",
+ [
+ pytest.param(
+ [
+ f"arn:aws:ecs:us-east-1:012345678910:task/{TASK_ID}",
+
"arn:aws:ecs:us-east-1:012345678910:task/d8c67b3c-ac87-4ffe-a847-4785bc3a8b54",
+ ],
+ f"arn:aws:ecs:us-east-1:012345678910:task/{TASK_ID}",
+ id="multiple-arns",
+ ),
+ pytest.param(
+ [
+ f"arn:aws:ecs:us-east-1:012345678910:task/{TASK_ID}",
+ ],
+ f"arn:aws:ecs:us-east-1:012345678910:task/{TASK_ID}",
+ id="simgle-arn",
+ ),
+ ],
)
+ @mock.patch("airflow.providers.amazon.aws.operators.ecs.generate_uuid")
@mock.patch.object(EcsRunTaskOperator, "_wait_for_task_ended")
@mock.patch.object(EcsRunTaskOperator, "_check_success_task")
@mock.patch.object(EcsRunTaskOperator, "_start_task")
@mock.patch.object(EcsBaseOperator, "client")
def test_reattach_successful(
- self,
- client_mock,
- start_mock,
- check_mock,
- wait_mock,
- xcom_pull_mock,
- xcom_del_mock,
- launch_type,
- tags,
+ self, client_mock, start_mock, check_mock, wait_mock, uuid_mock,
launch_type, tags, arns, expected_arn
):
+ """Test reattach on first running Task ARN."""
+ mock_ti = mock.MagicMock(name="MockedTaskInstance")
+ mock_ti.key.primary = ("mock_dag", "mock_ti", "mock_runid", 42)
+ dummy_uuid = "01-02-03-04"
Review Comment:
I don't have a good suggestion here, but I'm pretty sure we are supposed to
avoid using "dummy". Maybe just call it "fake_uuid" or "expected_uuid"??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
