[GitHub] [airflow] uranusjr commented on a diff in pull request #28777: Fix dag run conf encoding with non-JSON serializable values

Fri, 10 Feb 2023 01:33:21 -0800 


uranusjr commented on code in PR #28777:
URL: https://github.com/apache/airflow/pull/28777#discussion_r1102509392


##########
airflow/utils/json.py:
##########
@@ -71,7 +75,7 @@ def default(self, o: Any) -> Any:
                     return data[DATA]
             return data
         except TypeError:
-            raise
+            return repr(o)

Review Comment:
   Makes sense. We should probably mention this is the encoder’s docstring.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to