Abhiaps commented on PR #29375:
URL: https://github.com/apache/airflow/pull/29375#issuecomment-1427076083
@potiuk Actually as per what I read subTest can be used if we need to do
multiple tests with varying arguments. But here it was just a single test which
can be written via simple assert only.
So I am not sure why they used subTest here.
In one more PR in which I migrated tests/operator test functions, there were
several uses of subTest which makes a lot of sense, there they used for loop to
create several subTests with varying arguments.
But here I don't think it makes much sense of writing subTest if we can
simply write assert.
Just above in this PR only @Taragolis also commented that here subTest is
useless and can be easily replaced by regular assert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
