uranusjr commented on code in PR #29065:
URL: https://github.com/apache/airflow/pull/29065#discussion_r1104010648


##########
airflow/models/taskinstance.py:
##########
@@ -181,6 +182,7 @@ def clear_task_instances(
     task_id_by_key: dict[str, dict[str, dict[int, dict[int, set[str]]]]] = 
defaultdict(
         lambda: defaultdict(lambda: defaultdict(lambda: defaultdict(set)))
     )
+    dag_bag = DagBag(read_dags_from_db=True)

Review Comment:
   With this change yes, but without this PR `dag=None` would have a very weird 
behaviour and not particularly useful. This makes me think the signature may be 
considered a bug in the first place and fixed without introducing `DagBag` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to