josh-fell commented on code in PR #29502:
URL: https://github.com/apache/airflow/pull/29502#discussion_r1105872464
##########
airflow/providers/apache/hive/hooks/hive.py:
##########
@@ -141,6 +141,7 @@ def _prepare_cli_cmd(self) -> list[Any]:
if self.use_beeline:
hive_bin = "beeline"
+ self._validate_beeline_parameters(conn)
Review Comment:
The db call would only happen if an operator using this hook constructed the
hook in its `__init__`. There is _almost_ an instance of that in the
[HiveOperator](https://github.com/apache/airflow/blob/28126c12fbdd2cac84e0fbcf2212154085aa5ed9/airflow/providers/apache/hive/operators/hive.py#L119),
but it's to setup lazy loading the hook and make it an instance attr.
But yes, _ideally_ the constructors of hooks, operators, sensor, etc. don't
make any external calls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
