uranusjr commented on code in PR #28721:
URL: https://github.com/apache/airflow/pull/28721#discussion_r1105945820
##########
airflow/providers/sqlite/hooks/sqlite.py:
##########
@@ -33,13 +34,20 @@ class SqliteHook(DbApiHook):
def get_conn(self) -> sqlite3.dbapi2.Connection:
"""Returns a sqlite connection object"""
- conn_id = getattr(self, self.conn_name_attr)
- airflow_conn = self.get_connection(conn_id)
- conn = sqlite3.connect(airflow_conn.host)
+ # The sqlite3 connection does not use the sqlite prefix.
+ # See
https://docs.sqlalchemy.org/en/14/dialects/sqlite.html#connect-strings for
details.
+ uri = self.get_uri().replace("sqlite:///", "file:")
+ conn = sqlite3.connect(uri, uri=True)
Review Comment:
So you can’t use the `"sqlite://"` string (the default way to create an
in-memory SQLite database in SQLAlchemy) since no way to configure a connection
that formats into this specific string, but the same effect can be achieved
using the URL format, right? I wonder if we want to document this somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
