vincbeck commented on PR #28900:
URL: https://github.com/apache/airflow/pull/28900#issuecomment-1429978781
> Seems it also closes #29311
Not entirely. The method is not decorated with `@internal_api_call`. Though,
it is now pretty trivial to migrate it :). I am just not sure about this:
```
if self in session:
session.refresh(self,
TaskInstance.__mapper__.column_attrs.keys())
```
> Have you tested it (running e2e?) Don't you need to wait for #29355 to
have TaskInstance serializable?
No, I actually should have mentioned it but I have issues running Airflow
with `database_access_isolation` set to True. It is not related to
serialization but configuration. I think it would be actually helpful if you
could share a minimal `git diff` of your local configuration to run Airflow
with the feature on. So anybody who wants to test to feature just need to do a
`git apply`. Also, I am not sure the kind of testing needed to have a good
coverage of testing. I was thinking of running AWS system tests (for
convenience purposes), but I m not sure the coverage is good. How do you
usually test it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
