pierrejeambrun commented on PR #29513:
URL: https://github.com/apache/airflow/pull/29513#issuecomment-1430157598

   I took a look and overall I think you are right about user code here.
   
   I just have one question about the `gethostname()` call from within 
`check_and_change_state_before_execution`. That would now be called within the 
internal api server. Wondering if this is expected. This would be overriden by 
the following `self._run_raw_task` which also updates the TI hostname, but 
could this still change the task instance hostname value in an unexpeceted way ?
   
   What do you think ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to