mik-laj commented on a change in pull request #5585: [AIRFLOW-4951] Use new
style classes
URL: https://github.com/apache/airflow/pull/5585#discussion_r303217518
##########
File path: airflow/_vendor/nvd3/NVD3Chart.py
##########
@@ -36,7 +36,7 @@ def stab(tab=1):
return ' ' * 4 * tab
-class NVD3Chart(object):
+class NVD3Chart:
Review comment:
Changes should be made in the original repository, but we already have
changes in this directory.
https://github.com/apache/airflow/commits/master/airflow/_vendor
Secondly. This change does not change anything in the behavior of the
library, so it does not matter much. Changes to library behavior should not
have a place for sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
