dstandish commented on code in PR #28817:
URL: https://github.com/apache/airflow/pull/28817#discussion_r1106397651


##########
airflow/executors/base_executor.py:
##########
@@ -356,13 +356,13 @@ def execute_async(
         """
         raise NotImplementedError()
 
-    def get_task_log(self, ti: TaskInstance) -> tuple[list[str], list[str]]:
+    def get_task_log(self, ti: TaskInstance, try_number: int) -> 
tuple[list[str], list[str]]:
         """

Review Comment:
   wait this bit doesn't make sense to me.  if we already have the TI, why is 
it we also need to supply the try number?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to